linux-kernel - Re: [PATCH] rtw89: rtw89_ser: add const to struct state_ent and event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9455b32da137028a5c0d6dd010a247094d19309a.camel@realtek.com>
Date:   Fri, 8 Apr 2022 00:16:44 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "joe@...ches.com" <joe@...ches.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtw89: rtw89_ser: add const to struct state_ent and event_ent

On Thu, 2022-04-07 at 13:14 -0700, Joe Perches wrote:
> Change the struct and the uses to const to reduce data.
> 
> $ size drivers/net/wireless/realtek/rtw89/ser.o* (x86-64 defconfig w/ rtw89)
>    text	   data	    bss	    dec	    hex	filename
>    3741	      8	      0	   3749	    ea5	drivers/net/wireless/realtek/rtw89/ser.o.new
>    3437	    312	      0	   3749	    ea5	drivers/net/wireless/realtek/rtw89/ser.o.old
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

Thank you.

> ---
>  drivers/net/wireless/realtek/rtw89/core.h | 4 ++--
>  drivers/net/wireless/realtek/rtw89/ser.c  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
> index 771722132c53b..9bf56ce5ab43f 100644
> --- a/drivers/net/wireless/realtek/rtw89/core.h
> +++ b/drivers/net/wireless/realtek/rtw89/core.h
> @@ -2853,8 +2853,8 @@ struct rtw89_ser {
>  
>  	struct work_struct ser_hdl_work;
>  	struct delayed_work ser_alarm_work;
> -	struct state_ent *st_tbl;
> -	struct event_ent *ev_tbl;
> +	const struct state_ent *st_tbl;
> +	const struct event_ent *ev_tbl;
>  	struct list_head msg_q;
>  	spinlock_t msg_q_lock; /* lock when read/write ser msg */
>  	DECLARE_BITMAP(flags, RTW89_NUM_OF_SER_FLAGS);
> diff --git a/drivers/net/wireless/realtek/rtw89/ser.c b/drivers/net/wireless/realtek/rtw89/ser.c
> index 837cdc366a61a..7fbda7ef96bbb 100644
> --- a/drivers/net/wireless/realtek/rtw89/ser.c
> +++ b/drivers/net/wireless/realtek/rtw89/ser.c
> @@ -396,7 +396,7 @@ static void ser_l2_reset_st_hdl(struct rtw89_ser *ser, u8 evt)
>  	}
>  }
>  
> -static struct event_ent ser_ev_tbl[] = {
> +static const struct event_ent ser_ev_tbl[] = {
>  	{SER_EV_NONE, "SER_EV_NONE"},
>  	{SER_EV_STATE_IN, "SER_EV_STATE_IN"},
>  	{SER_EV_STATE_OUT, "SER_EV_STATE_OUT"},
> @@ -412,7 +412,7 @@ static struct event_ent ser_ev_tbl[] = {
>  	{SER_EV_MAXX, "SER_EV_MAX"}
>  };
>  
> -static struct state_ent ser_st_tbl[] = {
> +static const struct state_ent ser_st_tbl[] = {
>  	{SER_IDLE_ST, "SER_IDLE_ST", ser_idle_st_hdl},
>  	{SER_RESET_TRX_ST, "SER_RESET_TRX_ST", ser_reset_trx_st_hdl},
>  	{SER_DO_HCI_ST, "SER_DO_HCI_ST", ser_do_hci_st_hdl},
> 
> 
> ------Please consider the environment before printing this e-mail.