linux-kernel - Re: [PATCH v2] staging: rtl8723bs: remove unnecessary `if`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Apr 2022 17:12:35 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Yihao Han <hanyihao@...o.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Fabio Aiuto <fabioaiuto83@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Xiangyang Zhang <xyz.sun.ok@...il.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Bryan Brattlof <hello@...anbrattlof.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel@...o.com
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary `if`

On Fri, Apr 08, 2022 at 06:59:11AM -0700, Yihao Han wrote:
> remove a unnecesarry if in `sd_recv_rxfifo`
> 
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Yihao Han <hanyihao@...o.com>
> ---
  ^^^
Under this cut off line then you need to say what changed since version
1.  Something like: "v2: more extensive cleanup.  v3: edit commit message".

I do want you to edit the commit message because I don't think it really
describes the patch very well.  How I would write this commit message is
this:

    [PATCH v3] staging: rtl8723bs: tidy up error handling

    The check for if rtw_skb_alloc() fails is done twice and is written
    in a confusing way.  Move the "if (!recvbuf->pskb)" right after
    the allocation.  The "if (recvbuf->pskb)" check can now be deleted
    and the code pulled in one tab.

To me this explains the problem and the solution.

regards,
dan carpenter