linux-kernel - Re: [PATCH] perf: Add missing newline at end of file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70411972-e31a-27a1-acbf-26f5ab471a6a@linux.intel.com>
Date:   Fri, 8 Apr 2022 22:45:16 +0800
From:   Xing Zhengjun <zhengjun.xing@...ux.intel.com>
To:     "Liang, Kan" <kan.liang@...el.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andi Kleen <andi@...stfloor.org>,
        Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
Subject: Re: [PATCH] perf: Add missing newline at end of file



On 4/5/2022 9:59 PM, Liang, Kan wrote:
>
>> On Mon, Jun 17, 2019 at 6:00 PM Arnaldo Carvalho de Melo
>> <arnaldo.melo@...il.com> wrote:
>>> Em Mon, Jun 17, 2019 at 04:47:25PM +0200, Geert Uytterhoeven escreveu:
>>>> "git diff" says:
>>>>
>>>>      \ No newline at end of file
>>>>
>>>> after modifying the files.
>>> Auto generated files, IIRC, Andi, Kan, Sukadev?
>> The auto-generated files have been updated, the issue still exists.
>>
> It seems like a converter tool issue.
>
> + Zhengjun
>
> Zhengjun, could you please take a look?
>
> Thanks,
> Kan
It only happened for perf core event files. Add "\n" at the end of the 
perf core event file, then the issue is fixed.
I have updated the event convert tool 
https://github.com/intel/event-converter-for-linux-perf , then the next 
time uses the convert tool to generate perf events, the issue will be 
disappeared.

-- 
Zhengjun Xing