linux-kernel - Re: [PATCH v3] staging: rtl8723bs: tidy up error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220408145836.GV3293@kadam>
Date:   Fri, 8 Apr 2022 17:58:36 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Yihao Han <hanyihao@...o.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Fabio Aiuto <fabioaiuto83@...il.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Xiangyang Zhang <xyz.sun.ok@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Bryan Brattlof <hello@...anbrattlof.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel@...o.com
Subject: Re: [PATCH v3] staging: rtl8723bs: tidy up error handling

On Fri, Apr 08, 2022 at 07:44:40AM -0700, Yihao Han wrote:
> The check for if rtw_skb_alloc() fails is done twice and is written
> in a confusing way.  Move the "if (!recvbuf->pskb)" right after
> the allocation.  The "if (recvbuf->pskb)" check can now be deleted
> and the code pulled in one tab.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Yihao Han <hanyihao@...o.com>
> ---
> v2: more extensive cleanup
> v3: edit commit message

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter