linux-kernel - Re: [PATCH] NFSv4.2: Fix missing removal of SLAB_ACCOUNT on kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtV7Uf3Z1G-0WQNe_DukPz4t5HuxPRrNMVLJ1GVST9jQpA@mail.gmail.com>
Date:   Fri, 8 Apr 2022 23:21:07 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     trond.myklebust@...merspace.com, anna@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-nfs@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Xiongchun duan <duanxiongchun@...edance.com>,
        Muchun Song <smuchun@...il.com>, NeilBrown <neilb@...e.de>
Subject: Re: [PATCH] NFSv4.2: Fix missing removal of SLAB_ACCOUNT on
 kmem_cache allocation

Ping

Could someone be willing to help merge this?

On Fri, Apr 1, 2022 at 10:59 AM Muchun Song <songmuchun@...edance.com> wrote:
>
> The commit 5c60e89e71f8 ("NFSv4.2: Fix up an invalid combination of memory
> allocation flags") has stripped GFP_KERNEL_ACCOUNT down to GFP_KERNEL,
> however, it forgot to remove SLAB_ACCOUNT from kmem_cache allocation.
> It means that memory is still limited by kmemcg.  This patch also fix a
> NULL pointer reference issue [1] reported by NeilBrown.
>
> Link: https://lore.kernel.org/all/164870069595.25542.17292003658915487357@noble.neil.brown.name/ [1]
> Fixes: 5c60e89e71f8 ("NFSv4.2: Fix up an invalid combination of memory allocation flags")
> Fixes: 5abc1e37afa0 ("mm: list_lru: allocate list_lru_one only when needed")
> Reported-by: NeilBrown <neilb@...e.de>
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---
>  fs/nfs/nfs42xattr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs42xattr.c b/fs/nfs/nfs42xattr.c
> index ad3405c64b9e..e7b34f7e0614 100644
> --- a/fs/nfs/nfs42xattr.c
> +++ b/fs/nfs/nfs42xattr.c
> @@ -997,7 +997,7 @@ int __init nfs4_xattr_cache_init(void)
>
>         nfs4_xattr_cache_cachep = kmem_cache_create("nfs4_xattr_cache_cache",
>             sizeof(struct nfs4_xattr_cache), 0,
> -           (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> +           (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD),
>             nfs4_xattr_cache_init_once);
>         if (nfs4_xattr_cache_cachep == NULL)
>                 return -ENOMEM;
> --
> 2.11.0
>