linux-kernel - RE: [PATCH v2 1/2] block: add sync_blockdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Apr 2022 02:29:34 +0000
From:   "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     Namjae Jeon <linkinjeon@...nel.org>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "Andy.Wu@...y.com" <Andy.Wu@...y.com>,
        "Wataru.Aoyama@...y.com" <Wataru.Aoyama@...y.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
Subject: RE: [PATCH v2 1/2] block: add sync_blockdev_range()

> From: Christoph Hellwig <hch@...radead.org>
> > > This check isn't really needed, and I don't think we need a
> > > !CONFIG_BLOCK stub for this either.
> >
> > sync_blockdev() and related helpers have this check and a !CONFIG_BLOCK
> stub.
> > I would like to understand the background of your comment, could you
> explain a little more?
> 
> sync_blockdev and sync_blockdev do that because they are unconditionally
> called from sync_filesystem, and not just from block-dependent code.
> Eventually that should be cleaned up as well, but please don't add it to new
> code.

Thank you for your explanation.
I will update the patch to remove the check and the !CONFIG_BLOCK stub.