linux-kernel - Re: [PATCH v8 10/14] riscv: add cpufeature handling via alternatives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5557228.DvuYhMxLoT@diego>
Date:   Fri, 08 Apr 2022 18:13:39 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Christoph Hellwig <hch@....de>
Cc:     palmer@...belt.com, paul.walmsley@...ive.com,
        aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, wefu@...hat.com,
        liush@...winnertech.com, guoren@...nel.org, atishp@...shpatra.org,
        anup@...infault.org, drew@...gleboard.org, hch@....de,
        arnd@...db.de, wens@...e.org, maxime@...no.tech,
        gfavor@...tanamicro.com, andrea.mondelli@...wei.com,
        behrensj@....edu, xinhaoqu@...wei.com, mick@....forth.gr,
        allen.baum@...erantotech.com, jscheid@...tanamicro.com,
        rtrauben@...il.com, samuel@...lland.org, cmuellner@...ux.com,
        philipp.tomsich@...ll.eu
Subject: Re: [PATCH v8 10/14] riscv: add cpufeature handling via alternatives

Hi Christoph,

Am Donnerstag, 31. März 2022, 12:01:39 CEST schrieb Christoph Hellwig:
> Can you please fold the somewhat confusingly named vendor patching
> into this instead of keeping that magic standalone function pointer
> mess?

I'm not sure it's what you meant, but I did merge patches 10+11
(cpufeatures + svpbmt), as having them separate created build 
warnings / errors, when a bisected build happens (aka up to patch10
but without patch11)

The vendor-patch-func got an overhaul in patch13
"riscv: don't use global static vars to store alternative data"


> > +static const struct cpufeature_info __initdata_or_module cpufeature_list[CPUFEATURE_NUMBER] = {
> > +};
> 
> Overly lone line.

ok, I'll wrap that line


Heiko