linux-kernel - Re: [PATCH RESEND net-next v5 2/4] net: skb: rename SKB_DROP_REASON_PTYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d5c2bfc-cfb1-ea2d-f88c-36e0e4f92293@kernel.org>
Date:   Fri, 8 Apr 2022 21:50:19 -0600
From:   David Ahern <dsahern@...nel.org>
To:     menglong8.dong@...il.com, kuba@...nel.org, pabeni@...hat.com
Cc:     rostedt@...dmis.org, mingo@...hat.com, xeb@...l.ru,
        davem@...emloft.net, yoshfuji@...ux-ipv6.org,
        imagedong@...cent.com, edumazet@...gle.com, kafai@...com,
        talalahmad@...gle.com, keescook@...omium.org, alobakin@...me,
        flyingpeng@...cent.com, mengensun@...cent.com,
        dongli.zhang@...cle.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, benbjiang@...cent.com
Subject: Re: [PATCH RESEND net-next v5 2/4] net: skb: rename
 SKB_DROP_REASON_PTYPE_ABSENT

On 4/7/22 12:20 AM, menglong8.dong@...il.com wrote:
> From: Menglong Dong <imagedong@...cent.com>
> 
> As David Ahern suggested, the reasons for skb drops should be more
> general and not be code based.
> 
> Therefore, rename SKB_DROP_REASON_PTYPE_ABSENT to
> SKB_DROP_REASON_UNHANDLED_PROTO, which is used for the cases of no
> L3 protocol handler, no L4 protocol handler, version extensions, etc.
> 
> From previous discussion, now we have the aim to make these reasons
> more abstract and users based, avoiding code based.
> 
> Signed-off-by: Menglong Dong <imagedong@...cent.com>
> ---
>  include/linux/skbuff.h     | 8 +++-----
>  include/trace/events/skb.h | 2 +-
>  net/core/dev.c             | 8 +++-----
>  3 files changed, 7 insertions(+), 11 deletions(-)
> 


Reviewed-by: David Ahern <dsahern@...nel.org>