| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 Apr 2022 12:06:29 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Colton <cspur43@...il.com>
Cc: len.baker@....com, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: Staging: rtl8192e: rtllib_softmac_wx.c: Fixed multiple coding
style issues
On Sat, Apr 09, 2022 at 03:24:30AM -0500, Colton wrote:
> Staging: rtl8192e: rtllib_softmac_wx.c: Fixed multiple coding style issues
>
> Fixed issues with whitespace, unbalanced braces unnecessary (int) casts, and attempted to fix alignment issue still flagged by checkpatch.pl
>
> Signed-off-by: Colton Spurgin <cspur43@...il.com>
>
> From 42fd3afd5effcb667562a417e4e895fbc09cbc2c Mon Sep 17 00:00:00 2001
> From: Colton <cspur43@...il.com>
> Date: Sat, 9 Apr 2022 02:46:34 -0500
> Subject: [PATCH] Staging: rtl8192e: rtllib_softmac_wx.c: Fixed multiple coding
> style issues
>
> Fixed issues with whitespace, unbalanced braces unnecessary (int) casts, and attempted to fix alignment issue still flagged by checkpatch.pl
>
> Signed-off-by: Colton Spurgin <cspur43@...il.com>
> ---
> drivers/staging/rtl8192e/rtllib_softmac_wx.c | 42 ++++++--------------
> 1 file changed, 13 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> index 57a6d1130b6a..f67b829f28d1 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> @@ -12,7 +12,6 @@
> * own it's copyright ;-)
> */
> #include <linux/etherdevice.h>
> -
> #include "rtllib.h"
> #include "dot11d.h"
> /* FIXME: add A freqs */
> @@ -25,7 +24,6 @@ const long rtllib_wlan_frequencies[] = {
> };
> EXPORT_SYMBOL(rtllib_wlan_frequencies);
>
> -
> int rtllib_wx_set_freq(struct rtllib_device *ieee, struct iw_request_info *a,
> union iwreq_data *wrqu, char *b)
> {
> @@ -41,8 +39,8 @@ int rtllib_wx_set_freq(struct rtllib_device *ieee, struct iw_request_info *a,
>
> /* if setting by freq convert to channel */
> if (fwrq->e == 1) {
> - if ((fwrq->m >= (int) 2.412e8 &&
> - fwrq->m <= (int) 2.487e8)) {
> + if ((fwrq->m >= 2.412e8 &&
> + fwrq->m <= 2.487e8)) {
> int f = fwrq->m / 100000;
> int c = 0;
>
> @@ -83,7 +81,6 @@ int rtllib_wx_set_freq(struct rtllib_device *ieee, struct iw_request_info *a,
> }
> EXPORT_SYMBOL(rtllib_wx_set_freq);
>
> -
> int rtllib_wx_get_freq(struct rtllib_device *ieee,
> struct iw_request_info *a,
> union iwreq_data *wrqu, char *b)
> @@ -92,7 +89,7 @@ int rtllib_wx_get_freq(struct rtllib_device *ieee,
>
> if (ieee->current_network.channel == 0)
> return -1;
> - fwrq->m = rtllib_wlan_frequencies[ieee->current_network.channel-1] *
> + fwrq->m = rtllib_wlan_frequencies[ieee->current_network.channel - 1] *
> 100000;
> fwrq->e = 1;
> return 0;
> @@ -128,13 +125,11 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
> }
> EXPORT_SYMBOL(rtllib_wx_get_wap);
>
> -
> int rtllib_wx_set_wap(struct rtllib_device *ieee,
> struct iw_request_info *info,
> union iwreq_data *awrq,
> char *extra)
> {
> -
> int ret = 0;
> unsigned long flags;
>
> @@ -164,7 +159,6 @@ int rtllib_wx_set_wap(struct rtllib_device *ieee,
> goto out;
> }
>
> -
> if (ifup)
> rtllib_stop_protocol(ieee, true);
>
> @@ -220,7 +214,6 @@ int rtllib_wx_get_essid(struct rtllib_device *ieee, struct iw_request_info *a,
> spin_unlock_irqrestore(&ieee->lock, flags);
>
> return ret;
> -
> }
> EXPORT_SYMBOL(rtllib_wx_get_essid);
>
> @@ -228,10 +221,9 @@ int rtllib_wx_set_rate(struct rtllib_device *ieee,
> struct iw_request_info *info,
> union iwreq_data *wrqu, char *extra)
> {
> -
> u32 target_rate = wrqu->bitrate.value;
>
> - ieee->rate = target_rate/100000;
> + ieee->rate = target_rate / 100000;
> return 0;
> }
> EXPORT_SYMBOL(rtllib_wx_set_rate);
> @@ -250,16 +242,15 @@ int rtllib_wx_get_rate(struct rtllib_device *ieee,
> }
> EXPORT_SYMBOL(rtllib_wx_get_rate);
>
> -
> int rtllib_wx_set_rts(struct rtllib_device *ieee,
> struct iw_request_info *info,
> union iwreq_data *wrqu, char *extra)
> {
> if (wrqu->rts.disabled || !wrqu->rts.fixed)
> ieee->rts = DEFAULT_RTS_THRESHOLD;
> - else {
> + } else {
> if (wrqu->rts.value < MIN_RTS_THRESHOLD ||
> - wrqu->rts.value > MAX_RTS_THRESHOLD)
> + wrqu->rts.value > MAX_RTS_THRESHOLD)
> return -EINVAL;
> ieee->rts = wrqu->rts.value;
> }
> @@ -268,8 +259,8 @@ int rtllib_wx_set_rts(struct rtllib_device *ieee,
> EXPORT_SYMBOL(rtllib_wx_set_rts);
>
> int rtllib_wx_get_rts(struct rtllib_device *ieee,
> - struct iw_request_info *info,
> - union iwreq_data *wrqu, char *extra)
> + struct iw_request_info *info,
> + union iwreq_data *wrqu, char *extra)
> {
> wrqu->rts.value = ieee->rts;
> wrqu->rts.fixed = 0; /* no auto select */
> @@ -279,7 +270,7 @@ int rtllib_wx_get_rts(struct rtllib_device *ieee,
> EXPORT_SYMBOL(rtllib_wx_get_rts);
>
> int rtllib_wx_set_mode(struct rtllib_device *ieee, struct iw_request_info *a,
> - union iwreq_data *wrqu, char *b)
> + union iwreq_data *wrqu, char *b)
> {
> int set_mode_status = 0;
>
> @@ -410,7 +401,6 @@ void rtllib_wx_sync_scan_wq(void *data)
>
> out:
> mutex_unlock(&ieee->wx_mutex);
> -
> }
>
> int rtllib_wx_set_scan(struct rtllib_device *ieee, struct iw_request_info *a,
> @@ -441,7 +431,6 @@ int rtllib_wx_set_essid(struct rtllib_device *ieee,
> struct iw_request_info *a,
> union iwreq_data *wrqu, char *extra)
> {
> -
> int ret = 0, len, i;
> short proto_started;
> unsigned long flags;
> @@ -468,7 +457,6 @@ int rtllib_wx_set_essid(struct rtllib_device *ieee,
> if (proto_started)
> rtllib_stop_protocol(ieee, true);
>
> -
> /* this is just to be sure that the GET wx callback
> * has consistent infos. not needed otherwise
> */
> @@ -551,11 +539,10 @@ int rtllib_wx_get_name(struct rtllib_device *ieee, struct iw_request_info *info,
> }
> EXPORT_SYMBOL(rtllib_wx_get_name);
>
> -
> /* this is mostly stolen from hostap */
> int rtllib_wx_set_power(struct rtllib_device *ieee,
> - struct iw_request_info *info,
> - union iwreq_data *wrqu, char *extra)
> + struct iw_request_info *info,
> + union iwreq_data *wrqu, char *extra)
> {
> int ret = 0;
>
> @@ -601,19 +588,17 @@ int rtllib_wx_set_power(struct rtllib_device *ieee,
> default:
> ret = -EINVAL;
> goto exit;
> -
> }
> exit:
> mutex_unlock(&ieee->wx_mutex);
> return ret;
> -
> }
> EXPORT_SYMBOL(rtllib_wx_set_power);
>
> /* this is stolen from hostap */
> int rtllib_wx_get_power(struct rtllib_device *ieee,
> - struct iw_request_info *info,
> - union iwreq_data *wrqu, char *extra)
> + struct iw_request_info *info,
> + union iwreq_data *wrqu, char *extra)
> {
> mutex_lock(&ieee->wx_mutex);
>
> @@ -643,6 +628,5 @@ int rtllib_wx_get_power(struct rtllib_device *ieee,
> exit:
> mutex_unlock(&ieee->wx_mutex);
> return 0;
> -
> }
> EXPORT_SYMBOL(rtllib_wx_get_power);
> --
> 2.35.1
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch breaks the build.
- Your patch contains warnings and/or errors noticed by the
scripts/checkpatch.pl tool.
- Your patch was attached, please place it inline so that it can be
applied directly from the email message itself.
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
Powered by blists - more mailing lists