linux-kernel - Re: [PATCH 18/18] MIPS: DTS: CI20: fix bluetooth as reported by dtbscheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6AF3BDE5-856B-4D85-8810-433C1591C037@goldelico.com>
Date:   Sat, 9 Apr 2022 15:10:23 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 18/18] MIPS: DTS: CI20: fix bluetooth as reported by
 dtbscheck



> Am 09.04.2022 um 13:22 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>:
> 
> On 08/04/2022 20:38, H. Nikolaus Schaller wrote:
>> arch/mips/boot/dts/ingenic/ci20.dtb: bluetooth: vcc-supply does not match any of the regexes: pinctrl-[0-9]+
>> 	From schema: Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>> ---
>> arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
>> index dc587b4b36009..8a120f9374331 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -207,7 +207,7 @@ &uart2 {
>> 	bluetooth {
>> 		compatible = "brcm,bcm4330-bt";
>> 		reset-gpios = <&gpf 8 GPIO_ACTIVE_HIGH>;
>> -		vcc-supply = <&wlan0_power>;
>> +		vbat-supply = <&wlan0_power>;
> 
> Could be also vddio...

Good hint.

Schematics has both vbat AND vddio connected.

But with that finding, there is also a wifi_io regulator
for 2.5V. It is always-on and NOT yet controlled.

So this is worth a functional addition. But not related
to dtbscheck cleanup because it even is optional.
Hence a separate topic.

> 
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> 
> Best regards,
> Krzysztof

In summary for reviewing all patches: many thanks!

BR,
Nikolaus