linux-kernel - Re: [PATCH] block: Remove redundant assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <446a3e88-4c14-300d-862a-1279274c3760@gmail.com>
Date:   Sat, 9 Apr 2022 15:20:29 +0200
From:   Michal Orzel <michalorzel.eng@...il.com>
To:     Tom Rix <trix@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        "Richard Russon (FlatCap)" <ldm@...tcap.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-ntfs-dev@...ts.sourceforge.net, llvm@...ts.linux.dev
Subject: Re: [PATCH] block: Remove redundant assignments

Hi Tom,

> 
> On 4/9/22 3:19 AM, Michal Orzel wrote:
>> Get rid of redundant assignments which end up in values not being
>> read either because they are overwritten or the function ends.
> 
> This log is the same as your last patch.
> 
> Instead of a general statement on deadstores, a more specific
> 
> analysis of the setting being removed would be helpful.
> 
> This will mean splitting the patch to match the analysis.
> 
> Tom
> 

I think that this explanation in a commit is enough for such a trivial patch.
It informs that we are fixing clang-tidy findings related to deadstores
in a block subsystem. What analysis would you want to see?
Something like "Remove deadstore assignment ret = -EINVAL  in a function bio_map_user_iov" ?
I think that it will create too much of not needed overhead.

Cheers,
Michal