linux-kernel - Re: [PATCH v2] staging: wfx: use container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 09 Apr 2022 16:07:12 +0200
From:   Jérôme Pouiller <jerome.pouiller@...abs.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jaehee Park <jhpark1013@...il.com>,
        Stefano Brivio <sbrivio@...hat.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev,
        Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH v2] staging: wfx: use container_of() to get vif

On Friday 8 April 2022 07:44:24 CEST Stefano Brivio wrote:
> On Fri, 8 Apr 2022 06:45:52 +0200 Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> > On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote:
> > >
> > > [...]
> > >
> > > @@ -61,7 +63,6 @@ struct wfx_dev {
> > >
> > >  struct wfx_vif {
> > >     struct wfx_dev             *wdev;
> > > -   struct ieee80211_vif       *vif;
> >
> > You need to test this on real hardware.  For an outreachy-first-task,
> > this is not a good one at all.
> 
> We discussed about this on the outreachy list, and I suggested, as
> Jaehee also mentioned, that maybe somebody (Jérôme?) with the hardware
> could give it a try.
>
> It looks a bit difficult but it also looks almost correctly done now. :)

Absolutely.

I will test it once the various comments will be fixed.


-- 
Jérôme Pouiller