linux-kernel - Re: [PATCH] perf tools: Fix perf's libperf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YlGjN1YOKakAWSVx@kernel.org>
Date:   Sat, 9 Apr 2022 12:16:07 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix perf's libperf_print callback

Em Fri, Apr 08, 2022 at 04:26:25PM +0300, Adrian Hunter escreveu:
> eprintf does not expect va_list as the 4th parameter.
> Use veprintf because it does.

You forgot to add this:

Fixes: 428dab813a56ce94 ("libperf: Merge libperf_set_print() into libperf_init()")

Please consider doing it next time.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  tools/perf/perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/perf.c b/tools/perf/perf.c
> index 2f6b67189b42..6aae7b6c376b 100644
> --- a/tools/perf/perf.c
> +++ b/tools/perf/perf.c
> @@ -434,7 +434,7 @@ void pthread__unblock_sigwinch(void)
>  static int libperf_print(enum libperf_print_level level,
>  			 const char *fmt, va_list ap)
>  {
> -	return eprintf(level, verbose, fmt, ap);
> +	return veprintf(level, verbose, fmt, ap);
>  }
>  
>  int main(int argc, const char **argv)
> -- 
> 2.25.1

-- 

- Arnaldo