linux-kernel - Re: [V3 0/3] arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YlDQ7GyxSSIOsHVq@builder.lan>
Date:   Fri, 8 Apr 2022 19:18:52 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Vijaya Krishna Nivarthi <quic_vnivarth@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        quic_msavaliy@...cinc.com
Subject: Re: [V3 0/3] arch: arm64: dts: qcom: Configure cts sleep pinctrl to
 bias-bus-hold

On Wed 06 Apr 10:04 CDT 2022, Doug Anderson wrote:

> Hi,
> 
> On Wed, Apr 6, 2022 at 12:16 AM Vijaya Krishna Nivarthi
> <quic_vnivarth@...cinc.com> wrote:
> >
> > WLAN rail was leaking power during RBSC/sleep even after turning BT off.
> > Change sleep pinctrl configuration to handle same.
> >
> > ---
> > v3: apply same change to active state and other sc7280*.dts* as well
> > v2: used bias-bus-hold as per review comments
> > v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only
> > ---
> >
> > Vijaya Krishna Nivarthi (3):
> >   arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold
> >   arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold
> >   arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold
> >
> >  arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 12 ++++++------
> >  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi                   | 12 ++++++------
> >  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi                 | 13 ++++++++-----
> >  3 files changed, 20 insertions(+), 17 deletions(-)
> 
> Probably the subject of all the patches should be modified to talk
> about what each patch is applying to. Having 3 identically named
> patches is not ideal.
> 
> I'll let Bjorn chime in on whether he'd rather adjust the subject
> himself or whether he'd rather you re-send. In any case, with the
> subject modified then for all 3 patches:
> 

I've been fixing up a ton of these during the last few releases, so I
think it's time that I stop doing that.

Please resubmit this with subject prefixes that matches the existing git
log for each change.

> Reviewed-by: Douglas Anderson <dianders@...omium.org>

Thanks,
Bjorn