linux-kernel - Re: [Patch v6 2/4] memory: tegra: Add MC error logging on tegra186 onward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Apr 2022 17:55:06 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Ashish Mhetre <amhetre@...dia.com>, krzysztof.kozlowski@...aro.org,
        thierry.reding@...il.com, jonathanh@...dia.com, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org
Cc:     vdumpa@...dia.com, Snikam@...dia.com
Subject: Re: [Patch v6 2/4] memory: tegra: Add MC error logging on tegra186
 onward

06.04.2022 08:24, Ashish Mhetre пишет:
>  	/* clear interrupts */
> -	mc_writel(mc, status, MC_INTSTATUS);
> +	if (mc->soc->num_channels) {
> +		u32 status_chan_bit;
> +
> +		mc_ch_writel(mc, channel, status, MC_INTSTATUS);
> +		status_chan_bit = BIT(channel) << mc->soc->status_reg_chan_shift;

s/status_reg_chan_shift/global_intstatus_channel_shift/

> +		mc_ch_writel(mc, MC_BROADCAST_CHANNEL, status_chan_bit, MC_GLOBAL_INTSTATUS);
and maybe add a one-line mc_channel_to_global_intstatus(mc, channel) helper

mc_ch_writel(mc, MC_BROADCAST_CHANNEL,
	     mc_channel_to_global_intstatus(mc, chan), 
	     MC_GLOBAL_INTSTATUS);

> +	} else
> +		mc_writel(mc, status, MC_INTSTATUS);

Missing braces after "else", "./scripts/checkpatch.pl --strict" should warn about this.

Otherwise this patch looks okay at a quick glance.