linux-kernel - Re: [PATCH v12 6/7] xfs: Implement ->notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Apr 2022 02:58:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shiyang Ruan <ruansy.fnst@...itsu.com>,
        linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
        nvdimm@...ts.linux.dev, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, djwong@...nel.org,
        dan.j.williams@...el.com, david@...morbit.com, hch@...radead.org,
        jane.chu@...cle.com
Subject: Re: [PATCH v12 6/7] xfs: Implement ->notify_failure() for XFS

Hi Shiyang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hnaz-mm/master]
[also build test ERROR on next-20220408]
[cannot apply to xfs-linux/for-next linus/master linux/master v5.18-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Shiyang-Ruan/fsdax-introduce-fs-query-to-support-reflink/20220411-001048
base:   https://github.com/hnaz/linux-mm master
config: s390-defconfig (https://download.01.org/0day-ci/archive/20220411/202204110240.oa3G7lsW-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/bf68be0c39b8ecc4223b948a9ee126af167d74f0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Shiyang-Ruan/fsdax-introduce-fs-query-to-support-reflink/20220411-001048
        git checkout bf68be0c39b8ecc4223b948a9ee126af167d74f0
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   s390-linux-ld: fs/xfs/xfs_buf.o: in function `xfs_alloc_buftarg':
>> fs/xfs/xfs_buf.c:1968: undefined reference to `xfs_dax_holder_operations'
   pahole: .tmp_vmlinux.btf: No such file or directory
   .btf.vmlinux.bin.o: file not recognized: file format not recognized


vim +1968 fs/xfs/xfs_buf.c

  1955	
  1956	struct xfs_buftarg *
  1957	xfs_alloc_buftarg(
  1958		struct xfs_mount	*mp,
  1959		struct block_device	*bdev)
  1960	{
  1961		xfs_buftarg_t		*btp;
  1962	
  1963		btp = kmem_zalloc(sizeof(*btp), KM_NOFS);
  1964	
  1965		btp->bt_mount = mp;
  1966		btp->bt_dev =  bdev->bd_dev;
  1967		btp->bt_bdev = bdev;
> 1968		btp->bt_daxdev = fs_dax_get_by_bdev(bdev, &btp->bt_dax_part_off, mp,
  1969						    &xfs_dax_holder_operations);
  1970	
  1971		/*
  1972		 * Buffer IO error rate limiting. Limit it to no more than 10 messages
  1973		 * per 30 seconds so as to not spam logs too much on repeated errors.
  1974		 */
  1975		ratelimit_state_init(&btp->bt_ioerror_rl, 30 * HZ,
  1976				     DEFAULT_RATELIMIT_BURST);
  1977	
  1978		if (xfs_setsize_buftarg_early(btp, bdev))
  1979			goto error_free;
  1980	
  1981		if (list_lru_init(&btp->bt_lru))
  1982			goto error_free;
  1983	
  1984		if (percpu_counter_init(&btp->bt_io_count, 0, GFP_KERNEL))
  1985			goto error_lru;
  1986	
  1987		btp->bt_shrinker.count_objects = xfs_buftarg_shrink_count;
  1988		btp->bt_shrinker.scan_objects = xfs_buftarg_shrink_scan;
  1989		btp->bt_shrinker.seeks = DEFAULT_SEEKS;
  1990		btp->bt_shrinker.flags = SHRINKER_NUMA_AWARE;
  1991		if (register_shrinker(&btp->bt_shrinker))
  1992			goto error_pcpu;
  1993		return btp;
  1994	
  1995	error_pcpu:
  1996		percpu_counter_destroy(&btp->bt_io_count);
  1997	error_lru:
  1998		list_lru_destroy(&btp->bt_lru);
  1999	error_free:
  2000		kmem_free(btp);
  2001		return NULL;
  2002	}
  2003	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp