linux-kernel - Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b26a4e2-93a8-8b3f-20c3-c1593ea0d48b@lenbrook.com>
Date:   Sun, 10 Apr 2022 18:28:03 -0400
From:   Kevin Groeneveld <kgroeneveld@...brook.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Robin Gong <yibin.gong@....com>, dmaengine@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts

On 2022-04-08 13:39, Vinod Koul wrote:
> 1. Patch title should reflect the change introduced, so the title is not
> apt, pls revise

In hindsight the title was not very descriptive. I will update and send 
a v2. Maybe something like:

dmaengine: imx-sdma: fix init of uart scripts

> 2. Is this in response to rmk's report, if so, please add reported-by

No. I am not even aware of any report on this issue. I discovered the 
issue on my own and found the problem commit by doing a bisect.

> 3. Lastly, I would like to see some tested by for this patch..

I have tested on imx5, imx6 and imx8 systems. I will add some brief 
details of this to the commit message in the v2 patch. I am not sure if 
I as the author should include a Tested-by tag.

>> Fixes: b98ce2f4e32b ("dmaengine: imx-sdma: add uart rom script")
> 
> cc: stable ?

That sounds reasonable. I am relatively new to submitting kernel patches 
and that thought never crossed by mind.

Kevin