linux-kernel - Re: [PATCH] HWMON: Fixed comment error by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ae9f718d-e65b-9216-f90b-0bc463189834@roeck-us.net>
Date:   Sun, 10 Apr 2022 16:29:39 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Ozgur <ozgur@...ux.com>, Jean Delvare <jdelvare@...e.com>
Cc:     "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HWMON: Fixed comment error by checkpatch

On 4/10/22 16:07, Ozgur wrote:
>  From 3a50310ab617aecd5b86378f07d2500bc86935d4 Mon Sep 17 00:00:00 2001
> From: Ozgur <ozgur@...ux.com>
> Date: Mon, 11 Apr 2022 02:55:47 +0400
> Subject: [PATCH] HWMON: Fixed comment error by checkpatch
> Fixed a coding style issue and checkpatch errors.
> Signed-off-by: Ozgur <ozgur@...ux.com>

Please,
- Do not send corrupted patches.
- Follow patch submission guidelines when sending patches.
- Do not send patches fixing cosmetic issues like this one
   without making other relevant changes.

Guenter

> ---
>   drivers/hwmon/sch56xx-common.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
> index 3ece53adabd6..6ed0908c6037 100644
> --- a/drivers/hwmon/sch56xx-common.c
> +++ b/drivers/hwmon/sch56xx-common.c
> @@ -430,8 +430,9 @@ void sch56xx_watchdog_register(struct device *parent, u16 addr, u32 revision,
>                  set_bit(WDOG_HW_RUNNING, &data->wddev.status);
>          /* Since the watchdog uses a downcounter there is no register to read
> -          the BIOS set timeout from (if any was set at all) ->
> -          Choose a preset which will give us a 1 minute timeout */
> +        * the BIOS set timeout from (if any was set at all) ->
> +        * Choose a preset which will give us a 1 minute timeout
> +        */
>          if (control & SCH56XX_WDOG_TIME_BASE_SEC)
>                  data->watchdog_preset = 60; /* seconds */
>          else
> --
> 2.30.2