linux-kernel - Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8d3ed7196d09f5f6a61d605a94613f792ab501b.camel@pengutronix.de>
Date:   Mon, 11 Apr 2022 18:03:51 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        Maíra Canal <maira.canal@....br>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     hongxing.zhu@....com, robh@...nel.org, bhelgaas@...gle.com,
        helgaas@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, linux-imx@....com,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod
 interface

Hi Maíra, hi Lorenzo,

Am Montag, dem 11.04.2022 um 13:59 +0200 schrieb Francesco Dolcini:
> On Fri, Apr 08, 2022 at 11:46:32AM -0300, Maíra Canal wrote:
> > On Fri, Apr 08, 2022 at 03:23:39PM +0100, Lorenzo Pieralisi wrote:
> > > On Mon, Nov 01, 2021 at 10:03:11PM -0300, Maíra Canal wrote:
> > > > Considering the current transition of the GPIO subsystem, remove all
> > > > dependencies of the legacy GPIO interface (linux/gpio.h and linux
> > > > /of_gpio.h) and replace it with the descriptor-based GPIO approach.
> > > > 
> > > > Signed-off-by: Maíra Canal <maira.canal@....br>
> > > > ---
> > > > V1 -> V2: Rewrite commit log and subject line to match PCI subsystem standard
> > > > V2 -> v3: Change gpiod_set_value_cansleep for gpiod_set_raw_value_cansleep
> > > > ---
> > > >  drivers/pci/controller/dwc/pci-imx6.c | 30 +++++++++------------------
> > > >  1 file changed, 10 insertions(+), 20 deletions(-)
> > > 
> > > Maira, Lucas,
> > > 
> > > what's this patch status ? Please let me know.

The patch looks fine to me now, however...

> > 
> > Thank you for the feedback. Since I sent v3, I didn't get any feedback from the community.
> > 
> > If you have any feedback, I would gladly work on it.
> 
> Just for you to know that it will likely conflict with
> 'PCI: imx6: Fix PERST# start-up sequence' [0] that is also still waiting
> for some additional feedback.

... they do conflict and I guess the functional fix for the reset
sequence should have priority over this cleanup. Maíra, may I ask you
to respin your patch as soon as Francescos fix is in? I promise to not
let it fall through the cracks again.

Regards,
Lucas