linux-kernel - Re: [PATCH] firmware: turris-mox-rwtm: Fix return value check of wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Apr 2022 18:07:54 +0200
From:   Marek Behún <kabel@...nel.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: turris-mox-rwtm: Fix return value check of
 wait_for_completion_timeout

On Mon, 11 Apr 2022 10:45:38 +0000
Miaoqian Lin <linmq006@...il.com> wrote:

> wait_for_completion_timeout() returns unsigned long not int.
> It returns 0 if timed out, and positive if completed.
> The check for <= 0 is ambiguous and should be == 0 here
> indicating timeout which is the only error case
> 
> Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Marek Behún <kabel@...nel.org>