linux-kernel - Re: [PATCH 2/2] clk: qcom: add sc8280xp GCC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlR0B8N443IQZFEN@matsya>
Date:   Tue, 12 Apr 2022 00:01:35 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: add sc8280xp GCC driver

On 08-04-22, 15:43, Bjorn Andersson wrote:

> +static struct clk_branch gcc_aggre_ufs_card_axi_hw_ctl_clk = {
> +	.halt_reg = 0x750cc,
> +	.halt_check = BRANCH_HALT_VOTED,
> +	.hwcg_reg = 0x750cc,
> +	.hwcg_bit = 1,
> +	.clkr = {
> +		.enable_reg = 0x750cc,
> +		.enable_mask = BIT(1),
> +		.hw.init = &(struct clk_init_data){
> +			.name = "gcc_aggre_ufs_card_axi_hw_ctl_clk",
> +			.parent_hws = (const struct clk_hw*[]){
> +				&gcc_ufs_card_axi_clk_src.clkr.hw,
> +			},
> +			.num_parents = 1,
> +			.flags = CLK_SET_RATE_PARENT,
> +			.ops = &clk_branch2_ops, /* XXX: clk_branch2_hw_ctl_ops */

I think comment should be removed (couple of them here)

> +static struct clk_branch gcc_gpu_memnoc_gfx_clk = {
> +	.halt_reg = 0x71010,
> +	.halt_check = BRANCH_HALT_VOTED,
> +	.hwcg_reg = 0x71010,
> +	.hwcg_bit = 1,
> +	.clkr = {
> +		.enable_reg = 0x71010,
> +		.enable_mask = BIT(0),
> +		.hw.init = &(struct clk_init_data){
> +			.name = "gcc_gpu_memnoc_gfx_clk",
> +//			.flags = CLK_DONT_HOLD_STATE,

This need to be removed/updated

-- 
~Vinod