[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1fde1970-c7b7-a0a2-c68d-a3b26ec6621f@zago.net>
Date: Mon, 11 Apr 2022 16:38:31 -0500
From: Frank Zago <frank@...o.net>
To: Jiri Kosina <jikos@...nel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: Add support for Mega World controller force feedback
On 4/11/22 10:10, Jiri Kosina wrote:
> On Tue, 8 Feb 2022, frank zago wrote:
>
>> This patch adds support for one of the several Mega World USB game
>> controller with integrated force feedback. It is a HID based
>> memory-less game controller, with a weak motor on the left, and a
>> strong one on the right.
>>
>> Signed-off-by: frank zago <frank@...o.net>
>> ---
>> drivers/hid/Kconfig | 14 ++++
>> drivers/hid/Makefile | 1 +
>> drivers/hid/hid-ids.h | 3 +
>> drivers/hid/hid-megaworld.c | 136 ++++++++++++++++++++++++++++++++++++
>> 4 files changed, 154 insertions(+)
>> create mode 100644 drivers/hid/hid-megaworld.c
>>
>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>> index f5544157576c..2344830d3680 100644
>> --- a/drivers/hid/Kconfig
>> +++ b/drivers/hid/Kconfig
>> @@ -684,6 +684,20 @@ config HID_MAYFLASH
>> Say Y here if you have HJZ Mayflash PS3 game controller adapters
>> and want to enable force feedback support.
>>
>> +config HID_MEGAWORLD
>> + tristate "Mega World based game controller support"
>> + depends on HID
>> + help
>> + Say Y here if you have a Mega World based game controller.
>> +
>> +config MEGAWORLD_FF
>> + bool "Mega World based game controller force feedback support"
>> + depends on HID_MEGAWORLD
>> + select INPUT_FF_MEMLESS
>> + help
>> + Say Y here if you have a Mega World based game controller and want
>> + to have force feedback support for it.
>> +
>
> Hi Frank,
>
> as the *only* functionality provided by the driver seems to be the force
> feedback, does it really make sense to decouple the two options?
I don't think so, but that's what at least hid-tmff.c and hid-zpff.c are doing.
I can rework the patch if you prefer to just have the HID_MEGAWORLD option.
Frank.
Powered by blists - more mailing lists