linux-kernel - Re: [PATCH] ALSA: pcm: Test for "silence" field in struct "pcm_format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr164cc0i.wl-tiwai@suse.de>
Date:   Mon, 11 Apr 2022 09:30:53 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        syzbot+205eb15961852c2c5974@...kaller.appspotmail.com
Subject: Re: [PATCH] ALSA: pcm: Test for "silence" field in struct "pcm_format_data"

On Sat, 09 Apr 2022 03:26:55 +0200,
Fabio M. De Francesco wrote:
> 
> Syzbot reports "KASAN: null-ptr-deref Write in
> snd_pcm_format_set_silence".[1]
> 
> It is due to missing validation of the "silence" field of struct
> "pcm_format_data" in "pcm_formats" array.
> 
> Add a test for valid "pat" and, if it is not so, return -EINVAL.
> 
> [1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/
> 
> Reported-and-tested-by: syzbot+205eb15961852c2c5974@...kaller.appspotmail.com
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>

Thanks, applied now.


> ---
> 
> I wasn't able to figure out the commit for the "Fixes:" tag. If this patch
> is good, can someone please help with providing this missing information?

That must be present from the very beginning.
I just add Cc-to-stable for allowing backport to all releases.


thanks,

Takashi