lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Apr 2022 12:48:23 +0200 From: Bartosz Golaszewski <brgl@...ev.pl> To: Andrei Lalaev <andrei.lalaev@...id.com> Cc: Linus Walleij <linus.walleij@...aro.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] gpiolib: of: fix bounds check for valid mask On Mon, Apr 11, 2022 at 8:36 AM Andrei Lalaev <andrei.lalaev@...id.com> wrote: > > Use "greater" instead of "greater or equal" when performs bounds check > to make sure that GPIOS are in available range. Previous implementation > skipped ranges which include last GPIO in range. > > Signed-off-by: Andrei Lalaev <andrei.lalaev@...id.com> > --- > drivers/gpio/gpiolib-of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index ae1ce319cd78..7e5e51d49d09 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -910,7 +910,7 @@ static void of_gpiochip_init_valid_mask(struct gpio_chip *chip) > i, &start); > of_property_read_u32_index(np, "gpio-reserved-ranges", > i + 1, &count); > - if (start >= chip->ngpio || start + count >= chip->ngpio) > + if (start >= chip->ngpio || start + count > chip->ngpio) > continue; > > bitmap_clear(chip->valid_mask, start, count); > -- > 2.25.1 > Queued for fixes, good catch. Thanks Bart
Powered by blists - more mailing lists