linux-kernel - Re: [PATCH] dmaengine: pl08x: remove unneeded variable: "retval". Return "NULL"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlQ1i3DFqoFFFszO@matsya>
Date:   Mon, 11 Apr 2022 19:34:59 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: pl08x: remove unneeded variable: "retval".
 Return "NULL"

On 17-03-22, 18:22, Haowen Bai wrote:
> Unneeded variable: "retval". Return "NULL" , so we have to make code clear.
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  drivers/dma/amba-pl08x.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index a24882b..c70552a 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -1538,9 +1538,7 @@ static void pl08x_free_chan_resources(struct dma_chan *chan)
>  static struct dma_async_tx_descriptor *pl08x_prep_dma_interrupt(
>  		struct dma_chan *chan, unsigned long flags)
>  {
> -	struct dma_async_tx_descriptor *retval = NULL;
> -
> -	return retval;
> +	return NULL;

better way, drop the function?

>  }
>  
>  /*
> -- 
> 2.7.4

-- 
~Vinod