linux-kernel - Re: [PATCH 2/4] mm/migration: remove unneeded lock page and PageMovable check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Apr 2022 07:09:57 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, mike.kravetz@...cle.com,
        shy828301@...il.com, willy@...radead.org, ying.huang@...el.com,
        ziy@...dia.com, minchan@...nel.org, apopple@...dia.com,
        dave.hansen@...ux.intel.com, o451686892@...il.com,
        jhubbard@...dia.com, peterx@...hat.com, naoya.horiguchi@....com,
        mhocko@...e.com, riel@...hat.com, osalvador@...e.de,
        david@...hat.com, sfr@...b.auug.org.au, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mm/migration: remove unneeded lock page and
 PageMovable check

On Sat, Apr 09, 2022 at 03:38:44PM +0800, Miaohe Lin wrote:
> When non-lru movable page was freed from under us, __ClearPageMovable must
> have been done. Even if it's not done, ClearPageIsolated here won't hurt
> as page will be freed anyway. So we can thus remove unneeded lock page and
> PageMovable check here.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>