linux-kernel - Re: [PATCH] regmap: make range check functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdiBqJ_+1eewmgrdGpsYUr=+xLpeH+4B_rS4nDtc-fMYA@mail.gmail.com>
Date:   Mon, 11 Apr 2022 17:59:33 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regmap: make range check functions static

On Wed, Mar 30, 2022 at 11:17 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Tue, Mar 29, 2022 at 12:56:28AM +0200, Rasmus Villemoes wrote:
> > regmap_reg_in_ranges() and regmap_check_range_table() have no callers
> > outside regmap.c, so they have no reason to be exported nor have
> > external linkage.
>
> These are intentional API in case someone needs them, no need to
> encourage open coding.

But currently it's not used and simply consumes namespace resources.
Isn't it our practice not to add dead code / etc?

In practice I assume that one will grep before implementing, or at
least at review stage it may be pointed out for a helper, that might
be exported when needed, no?

-- 
With Best Regards,
Andy Shevchenko