linux-kernel - Re: [PATCH] of: fdt: do not reserve memory below MIN_MEMBLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 16:37:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Patrick Wang <patrick.wang.shcn@...il.com>, robh+dt@...nel.org,
        frowand.list@...il.com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        patrick.wang.shcn@...il.com
Subject: Re: [PATCH] of: fdt: do not reserve memory below MIN_MEMBLOCK_ADDR

Hi Patrick,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.18-rc2 next-20220412]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Patrick-Wang/of-fdt-do-not-reserve-memory-below-MIN_MEMBLOCK_ADDR/20220412-125309
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-buildonly-randconfig-r006-20220411 (https://download.01.org/0day-ci/archive/20220412/202204121637.4ZHpTqwT-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/d362274832c02bb7812c13eff968322a76f10ed3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Patrick-Wang/of-fdt-do-not-reserve-memory-below-MIN_MEMBLOCK_ADDR/20220412-125309
        git checkout d362274832c02bb7812c13eff968322a76f10ed3
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/of/fdt.c:494:4: warning: format specifies type 'unsigned long long' but the argument has type 'phys_addr_t' (aka 'unsigned int') [-Wformat]
                           base, phys_offset);
                           ^~~~
   include/linux/printk.h:499:37: note: expanded from macro 'pr_warn'
           printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
                                      ~~~     ^~~~~~~~~~~
   include/linux/printk.h:446:60: note: expanded from macro 'printk'
   #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
                                                       ~~~    ^~~~~~~~~~~
   include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
                   _p_func(_fmt, ##__VA_ARGS__);                           \
                           ~~~~    ^~~~~~~~~~~
   1 warning generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for DRM_GEM_SHMEM_HELPER
   Depends on HAS_IOMEM && DRM && MMU
   Selected by
   - DRM_SSD130X && HAS_IOMEM && DRM


vim +494 drivers/of/fdt.c

   486	
   487	static int __init early_init_dt_reserve_memory_arch(phys_addr_t base,
   488						phys_addr_t size, bool nomap)
   489	{
   490		const u64 phys_offset = MIN_MEMBLOCK_ADDR;
   491	
   492		if (base < phys_offset) {
   493			pr_warn("Ignoring reserved memory range 0x%llx - 0x%llx\n",
 > 494				base, phys_offset);
   495			size = (phys_offset - base) < size ?
   496				size - (phys_offset - base) : 0;
   497			base = phys_offset;
   498	
   499			if (!size)
   500				return -EFAULT;
   501		}
   502	
   503		if (nomap) {
   504			/*
   505			 * If the memory is already reserved (by another region), we
   506			 * should not allow it to be marked nomap, but don't worry
   507			 * if the region isn't memory as it won't be mapped.
   508			 */
   509			if (memblock_overlaps_region(&memblock.memory, base, size) &&
   510			    memblock_is_region_reserved(base, size))
   511				return -EBUSY;
   512	
   513			return memblock_mark_nomap(base, size);
   514		}
   515		return memblock_reserve(base, size);
   516	}
   517	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp