linux-kernel - Re: [PATCH] soc: ti: knav_dma: using pm_runtime_resume_and_get instead of pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48939b53-ede5-103a-ceae-9d7b9dcc4a1b@ti.com>
Date:   Tue, 12 Apr 2022 11:46:00 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     <cgel.zte@...il.com>, <nm@...com>
CC:     <ssantosh@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] soc: ti: knav_dma: using pm_runtime_resume_and_get
 instead of pm_runtime_get_sync



On 12/04/2022 11:29, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>   drivers/soc/ti/knav_dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index 700d8eecd8c4..061f92c8cf7d 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -747,9 +747,8 @@ static int knav_dma_probe(struct platform_device *pdev)
>   	INIT_LIST_HEAD(&kdev->list);
>   
>   	pm_runtime_enable(kdev->dev);
> -	ret = pm_runtime_get_sync(kdev->dev);
> +	ret = pm_runtime_resume_and_get(kdev->dev);
>   	if (ret < 0) {
> -		pm_runtime_put_noidle(kdev->dev);
>   		dev_err(kdev->dev, "unable to enable pktdma, err %d\n", ret);
>   		goto err_pm_disable;
>   	}

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
Best regards,
Grygorii, Ukraine