linux-kernel - Re: [PATCH v7 2/2] dt-bindings:thermal: Add Sunplus SP7021 schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36b7de46-7e8b-fbb5-6eeb-89180d358d84@kernel.org>
Date:   Tue, 12 Apr 2022 10:48:21 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Li-hao Kuo <lhjeff911@...il.com>, rafael@...nel.org,
        daniel.lezcano@...aro.org, amitk@...nel.org, rui.zhang@...el.com,
        robh+dt@...nel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     wells.lu@...plus.com, lh.kuo@...plus.com
Subject: Re: [PATCH v7 2/2] dt-bindings:thermal: Add Sunplus SP7021 schema

On 11/04/2022 10:52, Li-hao Kuo wrote:
> Add bindings for Sunplus SP7021 thermal driver
> 
> Signed-off-by: Li-hao Kuo <lhjeff911@...il.com>

Thank you for your patch. There is something to discuss/improve.

> ---
> Changes in v7:
>  - Modify yaml file.
>  - Change the filename sunplus_thermal to sunplus-thermal.
>  - Change the nvmem-cell-names thermal_calib to calib.
> 
>  .../bindings/thermal/sunplus-thermal.yaml          | 43 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml
> 

I commented with v5 [1] how the naming should look like. That's the
Devicetree convention.

You sent v6 without implementing the changes. I pointed out that you did
not follow what I asked for.
Now you sent v7 also without implementing these changes, again.

You also did not discuss it with me, did not come with counter
arguments, other proposals. Therefore it looks like either you
misunderstood me or you ignored my comments.

Let's assume first case, so I will repeat. Name should be one of:
1. sunplus,thermal.yaml
2. sunplus,sp7021-thermal.yaml

Not other names. No other characters, no undescores, no hyphens after
vendor name. If this is unclear, please respond instead of ignoring.

Without implementing the changes:
NAK

[1]
https://lore.kernel.org/linux-devicetree/fe67c7e7-957b-3abf-a929-5ee346657bcf@canonical.com/

Best regards,
Krzysztof