linux-kernel - Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlVOAw9yUbivp7Ki@hirez.programming.kicks-ass.net>
Date:   Tue, 12 Apr 2022 12:01:39 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Dmitry Monakhov <dmtrmonakhov@...dex-team.ru>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, mingo@...hat.com
Subject: Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for
 deref_stack_iret_regs

On Tue, Apr 12, 2022 at 10:40:04AM +0300, Dmitry Monakhov wrote:
> For historical reasons we check only IRET_FRAME_OFFSET, but this check
> is no longer valid because  we also access regs->sp field which is
> located beyond IRET_FRAME, so it is reasonable to validate full structure.

Uuuh, what? IRET frame is:

 ss, sp, flags, cs, ip

that very much includes sp.