linux-kernel - Re: [PATCH] hsi: clients: remove duplicate assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 12:00:09 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Qing Wang <wangqing@...o.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hsi: clients: remove duplicate assignment

Hi,

On Thu, Mar 31, 2022 at 05:07:38AM -0700, Qing Wang wrote:
> From: Wang Qing <wangqing@...o.com>
> 
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/hsi/clients/ssi_protocol.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
> index 21f11a5..7aacb19
> --- a/drivers/hsi/clients/ssi_protocol.c
> +++ b/drivers/hsi/clients/ssi_protocol.c
> @@ -796,7 +796,6 @@ static void ssip_rx_strans(struct hsi_client *cl, u32 cmd)
>  		dev_err(&cl->device, "No memory for rx skb\n");
>  		goto out1;
>  	}
> -	skb->dev = ssi->netdev;
>  	skb_put(skb, len * 4);
>  	msg = ssip_alloc_data(ssi, skb, GFP_ATOMIC);
>  	if (unlikely(!msg)) {
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)