linux-kernel - Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <258541649761055@myt5-132c43df2a33.qloud-c.yandex.net>
Date:   Tue, 12 Apr 2022 13:57:35 +0300
From:   Dmitry Monakhov <dmtrmonakhov@...dex-team.ru>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, mingo@...hat.com
Subject: Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret_regs



> On Tue, Apr 12, 2022 at 10:40:04AM +0300, Dmitry Monakhov wrote:
> 
>> For historical reasons we check only IRET_FRAME_OFFSET, but this check
>> is no longer valid because we also access regs->sp field which is
>> located beyond IRET_FRAME, so it is reasonable to validate full structure.
> 
> Uuuh, what? IRET frame is:
> 
> ss, sp, flags, cs, ip
> 
> that very much includes sp.
Oh. Indeed you are right. Sorry. Please ignore this patch.