linux-kernel - Re: [PATCH 3/3] tty: serial: altera: use altera_jtaguart_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 13:24:45 +0200
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] tty: serial: altera: use altera_jtaguart_stop_tx()

On 2022-04-11 at 12:45:06 +0200, Jiri Slaby <jslaby@...e.cz> wrote:
> altera_jtaguart_tx_chars() duplicates what altera_jtaguart_stop_tx()
> already does. So instead of the duplication, call the helper instead.
> 
> Not only it makes the code cleaner, but it also says what the "if"
> really does.
> 
> Cc: Tobias Klauser <tklauser@...tanz.ch>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Acked-by: Tobias Klauser <tklauser@...tanz.ch>

Thanks