linux-kernel - Re: [PATCH 1/1] mips: cpc: Fix refcount leak in mips_cpc_default_phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220412130537.j4mlsz2xzuk4t3lw@mobilestation>
Date:   Tue, 12 Apr 2022 16:05:37 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Yuanjun Gong <ruc_gongyuanjun@....com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mips: cpc: Fix refcount leak in
 mips_cpc_default_phys_base

To += @Thomas

On Thu, Apr 07, 2022 at 12:26:57PM +0800, Yuanjun Gong wrote:
> From: Gong Yuanjun <ruc_gongyuanjun@....com>
> 

> Add the missing of_node_put() to release the refcount incremented
> by of_find_compatible_node().

Right, the same bug was fixed in the CDMM driver:
https://lore.kernel.org/linux-mips/20220309091711.3850-1-linmq006@gmail.com/

Good catch. Thanks.
Reviewed-by: Serge Semin <fancer.lancer@...il.com>

-Sergey

> 
> Signed-off-by: Gong Yuanjun <ruc_gongyuanjun@....com>
> ---
>  arch/mips/kernel/mips-cpc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
> index 17aff13cd7ce..3e386f7e1545 100644
> --- a/arch/mips/kernel/mips-cpc.c
> +++ b/arch/mips/kernel/mips-cpc.c
> @@ -28,6 +28,7 @@ phys_addr_t __weak mips_cpc_default_phys_base(void)
>  	cpc_node = of_find_compatible_node(of_root, NULL, "mti,mips-cpc");
>  	if (cpc_node) {
>  		err = of_address_to_resource(cpc_node, 0, &res);
> +		of_node_put(cpc_node);
>  		if (!err)
>  			return res.start;
>  	}
> -- 
> 2.17.1
>