linux-kernel - Re: [PATCH] wireless: ipw2x00: Refine the error handling of ipw2100_pci_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <164977173724.30373.497076954212523434.kvalo@kernel.org>
Date:   Tue, 12 Apr 2022 13:55:39 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Zheyu Ma <zheyuma97@...il.com>
Cc:     stas.yakovlev@...il.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zheyu Ma <zheyuma97@...il.com>
Subject: Re: [PATCH] wireless: ipw2x00: Refine the error handling of
 ipw2100_pci_init_one()

Zheyu Ma <zheyuma97@...il.com> wrote:

> The driver should release resources in reverse order, i.e., the
> resources requested first should be released last, and the driver
> should adjust the order of error handling code by this rule.
> 
> Signed-off-by: Zheyu Ma <zheyuma97@...il.com>

Can someone review this, please?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220409062449.3752252-1-zheyuma97@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches