linux-kernel - Re: [PATCH v3] usb: usbip: fix a refcount leak in stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 08:44:34 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Hangyu Hua <hbh25y@...il.com>, valentina.manea.m@...il.com,
        shuah@...nel.org, gregkh@...uxfoundation.org, khoroshilov@...ras.ru
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] usb: usbip: fix a refcount leak in stub_probe()

On 4/11/22 8:02 PM, Hangyu Hua wrote:
> usb_get_dev() is called in stub_device_alloc(). When stub_probe() fails
> after that, usb_put_dev() needs to be called to release the reference.
> 
> Fix this by moving usb_put_dev() to sdev_free error path handling.
> 
> Find this by code review.
> 
> Fixes: 3ff67445750a ("usbip: fix error handling in stub_probe()")
> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> ---
> 
> v2: add more description of this patch.
> 
> v3: add how to find the problem.
> 

Thank you.

Greg, Please pick this patch up.

thanks,
-- Shuah