linux-kernel - Re: [PATCH v6 4/7] net: phy: Add 10BASE-T1L support in phy-c45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220412094524.178b8785@kernel.org>
Date:   Tue, 12 Apr 2022 09:45:24 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <alexandru.tachici@...log.com>
Cc:     <andrew@...n.ch>, <o.rempel@...gutronix.de>, <davem@...emloft.net>,
        <devicetree@...r.kernel.org>, <hkallweit1@...il.com>,
        <linux-kernel@...r.kernel.org>, <linux@...linux.org.uk>,
        <netdev@...r.kernel.org>, <robh+dt@...nel.org>
Subject: Re: [PATCH v6 4/7] net: phy: Add 10BASE-T1L support in phy-c45

On Tue, 12 Apr 2022 16:07:03 +0300 alexandru.tachici@...log.com wrote:
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 36ca2b5c2253..6c3048e2a3ce 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -698,6 +698,8 @@ struct phy_device {
>  	u8 mdix;
>  	u8 mdix_ctrl;
>  
> +	int pma_extable;
> +
>  	void (*phy_link_change)(struct phy_device *phydev, bool up);
>  	void (*adjust_link)(struct net_device *dev);

kdoc warning here:

include/linux/phy.h:711: warning: Function parameter or member 'pma_extable' not described in 'phy_device'

Please allow at least 24h between postings to collect additional
feedback.