linux-kernel - Re: [PATCH] staging: r8188eu: correct multiple misspellings in driver r8188eu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 12:18:50 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Dave Jiang <dave.jiang@...el.com>,
        Mahak Gupta <mahak_g@...iitr.ac.in>, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: r8188eu: correct multiple misspellings in driver
 r8188eu

On 4/11/22 16:28, Dave Jiang wrote:
> Subject:
> 
> staging: r8188eu: fix multiple spelling errors in driver source
> 
> Given that it already annotated that it's the r8188eu driver, no need to add "in 
> driver r8188eu".
> 
> Maybe the log can be something less terse:
> 
> Fix multiple spelling errors reported by checkpatch.
> 
> 
> Probably doesn't hurt to fix other issues on the same line while you are at it. 
> See below...

Wrong on the first and last points. That subject is exactly what should be used 
- it describes what is being modified.

A given patch should fix one, and only one, problem.

Yes, the commit message could be less terse, but that is not a problem.

Larry