linux-kernel - Re: [PATCH v1] clang-format: Update and extend the for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mpdYY6Un6UZ49r05AJir_F4xRur9Ecmjw8v8CCWhLJ2w@mail.gmail.com>
Date:   Tue, 12 Apr 2022 19:35:43 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Mickaël Salaün <mic@...ikod.net>
Cc:     Shuah Khan <skhan@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        Miguel Ojeda <ojeda@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, bpf <bpf@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        llvm@...ts.linux.dev,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v1] clang-format: Update and extend the for_each list with tools/

On Tue, Apr 12, 2022 at 7:05 PM Mickaël Salaün <mic@...ikod.net> wrote:
>
> I'm wondering about the ASSERT_* and EXPECT_* macros from
> tools/testing/selftests/kselftest_harness.h
> Do you think we should treat them as "for macros" as well? They can
> either be used with or without a following code block.

I would keep the style that we have in the kernel -- as far as I can
see, that means without a space.

Also, from a quick grep, it seems most callers do not use the optional
handler, which also makes sense w.r.t. not using a space.

Cheers,
Miguel