linux-kernel - Re: [PATCH] scsi: mpi3mr: Fix an error code when probing the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFdVvOzx7t99Btf4Jv5+5=6es0i8AKx_1Bwj5gQd-Oqnqi+tPA@mail.gmail.com>
Date:   Tue, 12 Apr 2022 11:58:12 -0600
From:   Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>
To:     Zheyu Ma <zheyuma97@...il.com>
Cc:     Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        jejb@...ux.ibm.com,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        mpi3mr-drvr-developers <mpi3mr-linuxdrv.pdl@...adcom.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: mpi3mr: Fix an error code when probing the driver

On Sat, Apr 9, 2022 at 7:49 AM Zheyu Ma <zheyuma97@...il.com> wrote:
>
> During the process of driver probing, probe function should return < 0
> for failure, otherwise kernel will treat value >= 0 as success.
>
> Signed-off-by: Zheyu Ma <zheyuma97@...il.com>
> ---
>  drivers/scsi/mpi3mr/mpi3mr_os.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> index f7cd70a15ea6..240bfdf9788b 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> @@ -4222,9 +4222,10 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>         struct Scsi_Host *shost = NULL;
>         int retval = 0, i;
>
> -       if (osintfc_mrioc_security_status(pdev)) {
> +       retval = osintfc_mrioc_security_status(pdev);
> +       if (retval) {
>                 warn_non_secure_ctlr = 1;
> -               return 1; /* For Invalid and Tampered device */
> +               return retval; /* For Invalid and Tampered device */
>         }
NAK. The driver has to return 1 when invalid/tampered controllers are
detected just to say the controller is held by the mpi3mr driver
without any actual operation.
>
>         shost = scsi_host_alloc(&mpi3mr_driver_template,
> --
> 2.25.1
>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4227 bytes)