linux-kernel - Re: [Intel-wired-lan] [PATCH] ice: wait for EMP reset after firmware flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 11:29:48 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        Petr Oros <poros@...hat.com>
CC:     <ivecera@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <davem@...emloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] ice: wait for EMP reset after firmware
 flash

On 4/12/2022 9:08 AM, Alexander Lobakin wrote:

>> +#define ICE_EMP_RESET_SLEEP 5000
> 
> Ooof, 5 sec is a lot! Is there any way to poll the device readiness?
> Does it really need the whole 5 sec?

The problem with resets is usually you don't want to disturb the 
hardware with PCIe pokes while it's resetting. In this case, this code 
only runs if it was indicated by the update status that the firmware 
could internally reset itself to pick up new updates, avoiding a reboot.

Yes the five seconds is less than ideal, but it was the value we found 
that offered the most stability / likelihood of reset completing. In 
this case the 5 seconds is a tradeoff vs a reboot.

Thank you Ivan for chasing down this bug!