linux-kernel - Re: [PATCH] firmware: cs_dsp: Fix overrun of unterminated control name string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164979303081.449327.16793414512968400823.b4-ty@kernel.org>
Date:   Tue, 12 Apr 2022 20:50:30 +0100
From:   Mark Brown <broonie@...nel.org>
To:     rf@...nsource.cirrus.com
Cc:     alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: cs_dsp: Fix overrun of unterminated control name string

On Tue, 12 Apr 2022 17:39:27 +0100, Richard Fitzgerald wrote:
> For wmfw format v2 and later the coefficient name strings have a length
> field and are NOT null-terminated. Use kasprintf() to convert the
> unterminated string into a null-terminated string in an allocated buffer.
> 
> The previous code handled this duplication incorrectly using kmemdup()
> and getting the length from a strlen() of the (unterminated) source string.
> This resulted in creating a string that continued up to the next byte in
> the firmware file that just happened to be 0x00.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] firmware: cs_dsp: Fix overrun of unterminated control name string
      commit: 5b933c7262c5b0ea11ea3c3b3ea81add04895954

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark