linux-kernel - Re: [PATCH -next RFC v2 8/8] sbitmap: wake up the number of threads based on required tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7095eedb-91a7-e8d6-f30b-91aa65de3533@acm.org>
Date:   Mon, 11 Apr 2022 20:20:32 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "yukuai (C)" <yukuai3@...wei.com>, axboe@...nel.dk,
        andriy.shevchenko@...ux.intel.com, john.garry@...wei.com,
        ming.lei@...hat.com
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH -next RFC v2 8/8] sbitmap: wake up the number of threads
 based on required tags

On 4/9/22 00:01, yukuai (C) wrote:
> For the race that new threads are waited after get_wake_nr() and before
> wake_up_nr() in situation (b), I can't figure out how this can be
> problematic [ ... ]

If the atomic_dec_return() statement in __sbq_wake_up() returns a value 
that is less than or equal to zero, wake_batch waiters should be woken 
up or I/O will hang until sbitmap_queue_wake_all() is called. That last 
function should not be called unless there is no alternative.

Thanks,

Bart.