linux-kernel - Re: [PATCH 0/4] A few cleanup and fixup patches for migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <880376f0-f480-979b-261f-72cf9475474c@huawei.com>
Date:   Tue, 12 Apr 2022 11:29:31 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     "ying.huang@...el.com" <ying.huang@...el.com>
CC:     <mike.kravetz@...cle.com>, <shy828301@...il.com>,
        <willy@...radead.org>, <ziy@...dia.com>, <minchan@...nel.org>,
        <apopple@...dia.com>, <dave.hansen@...ux.intel.com>,
        <o451686892@...il.com>, <jhubbard@...dia.com>, <peterx@...hat.com>,
        <naoya.horiguchi@....com>, <mhocko@...e.com>, <riel@...hat.com>,
        <osalvador@...e.de>, <david@...hat.com>, <sfr@...b.auug.org.au>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 0/4] A few cleanup and fixup patches for migration

On 2022/4/12 10:25, ying.huang@...el.com wrote:
> On Sat, 2022-04-09 at 15:38 +0800, Miaohe Lin wrote:
>> Hi everyone,
>> This series contains a few patches to remove unneeded lock page and
>> PageMovable check, reduce the rcu lock duration. Also we fix potential
>> pte_unmap on an not mapped pte. More details can be found in the
>> respective changelogs. Thanks!
> 
> It appears that you ignored my comments for the previous version.  Can
> you check it?

I do remember [1] and I tried to make isolate_huge_page consistent with isolate_lru_page.
But their return value conventions are different. isolate_huge_page return 0 when
success while isolate_huge_page returns true in this case. So make them consistent
would lead to many code change. I should have added this in my changelog.

Thanks.

[1] https://lore.kernel.org/linux-mm/8735jsgctq.fsf@yhuang6-desk2.ccr.corp.intel.com/


> 
> Best Regards,
> Huang, Ying
> 
>> ---
>> v1:
>>   rebase [1] on mainline.
>>
>> [1] https://lore.kernel.org/lkml/20220304093409.25829-2-linmiaohe@huawei.com/T/
>> ---
>> Miaohe Lin (4):
>>   mm/migration: reduce the rcu lock duration
>>   mm/migration: remove unneeded lock page and PageMovable check
>>   mm/migration: return errno when isolate_huge_page failed
>>   mm/migration: fix potential pte_unmap on an not mapped pte
>>
>>  include/linux/migrate.h |  2 +-
>>  include/linux/swapops.h |  4 ++--
>>  mm/filemap.c            | 10 +++++-----
>>  mm/hugetlb.c            |  2 +-
>>  mm/migrate.c            | 31 +++++++++++++------------------
>>  5 files changed, 22 insertions(+), 27 deletions(-)
>>
> 
> 
> 
> .
>