linux-kernel - Re: [PATCH 1/1] iommu/vt-d: Change return type of dmar_insert_one_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d87918be-9ab8-ca6b-ea1f-b6e9fafb1d44@linux.intel.com>
Date:   Tue, 12 Apr 2022 13:13:38 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     baolu.lu@...ux.intel.com, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] iommu/vt-d: Change return type of
 dmar_insert_one_dev_info()

On 2022/4/11 22:26, Christoph Hellwig wrote:
> On Sat, Apr 09, 2022 at 09:30:06PM +0800, Lu Baolu wrote:
>> The dmar_insert_one_dev_info() returns the pass-in domain on success and
>> NULL on failure. This doesn't make much sense. Change it to an integer.
> 
> Looks sensibel.  Why not also merge it with domain_add_dev_info while
> you're at it?

It looks cleaner that way. Thanks a lot!

Best regards,
baolu