linux-kernel - Re: [PATCH] security: do not leak information in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Apr 2022 22:25:38 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Tom Rix <trix@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>, tim@...erelk.net,
        axboe@...nel.dk, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        nathan@...nel.org, ndesaulniers@...gle.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] security: do not leak information in ioctl

On Mon, Apr 11, 2022 at 09:31:20AM -0700, Tom Rix wrote:
> The failure can happen in the transfer loop, so some of the data will not be
> zero.
> 
> And checking status should be done.
> 
> zero-ing is because i am paranoid.

Maybe I'm just lost because of all the reformating.  Please do a first
patch that split the CDROMREADTOCHDR and CDROMREADTOCENTRY into one
helper each and the just do the minimal fix on top so that it is
reviewable.