linux-kernel - Re: [PATCH v11] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Apr 2022 11:15:58 +0530
From:   Manikanta Pubbisetty <quic_mpubbise@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <robh+dt@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_sibis@...cinc.com>,
        <kuabhs@...omium.org>, <quic_pillair@...cinc.com>
Subject: Re: [PATCH v11] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

On 4/7/2022 11:46 PM, Stephen Boyd wrote:
> Quoting Manikanta Pubbisetty (2022-04-06 23:11:50)
>>
>>
>> On 4/6/2022 8:47 PM, Stephen Boyd wrote:
>>> Quoting Manikanta Pubbisetty (2022-04-06 04:11:01)
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>>> index ecbf2b89d896..f61a3e15fa8b 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>>> @@ -547,3 +547,6 @@ sw_ctrl: sw-ctrl {
>>>>           };
>>>>    };
>>>>
>>>> +&remoteproc_wpss {
>>>> +       status = "okay";
>>>> +};
>>>
>>> This should be before the PINCTRL section in this file. I believe after
>>> the uart node.
>>
>> I have not understood your concern, any specific reason as why
>> remoteproc_wpss node has to be before PINCTRL section?
>> There is no problem in moving, just wanted to understand the reason.
>>
> 
> It's a style that this file is following. The end of the file is for
> pinctrl configurations. Before that section is where soc nodes are
> modified. There are different sections of the file with comments
> delineating them.
> 
> Furthermore, adding things to the end of the file is a recipe for
> conflicts when applying patches as a maintainer. This is another reason
> why we sort the nodes. I suspect having different sections helps here so
> that we don't sort everything alphabetically and have pinctrl settings
> scattered throughout the file.

Thanks for the explanation, I'll send out a revised patch.

Manikanta