linux-kernel - RE: [PATCH] iio: proximity: Fix return value check of wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR03MB6786F62DE142E3E2C66C937F99ED9@PH0PR03MB6786.namprd03.prod.outlook.com>
Date:   Tue, 12 Apr 2022 06:23:45 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Miaoqian Lin <linmq006@...il.com>,
        Song Qiang <songqiang1304521@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Ivan Drobyshevskyi <drobyshevskyi@...il.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: proximity: Fix return value check of
 wait_for_completion_timeout

> From: Sa, Nuno
> Sent: Tuesday, April 12, 2022 8:21 AM
> To: Miaoqian Lin <linmq006@...il.com>; Song Qiang
> <songqiang1304521@...il.com>; Jonathan Cameron
> <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; Ivan
> Drobyshevskyi <drobyshevskyi@...il.com>; linux-
> iio@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH] iio: proximity: Fix return value check of
> wait_for_completion_timeout
> 
> 
> 
> > -----Original Message-----
> > From: Miaoqian Lin <linmq006@...il.com>
> > Sent: Tuesday, April 12, 2022 5:00 AM
> > To: Song Qiang <songqiang1304521@...il.com>; Jonathan Cameron
> > <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; Ivan
> > Drobyshevskyi <drobyshevskyi@...il.com>; linux-
> > iio@...r.kernel.org; linux-kernel@...r.kernel.org
> > Cc: linmq006@...il.com
> > Subject: [PATCH] iio: proximity: Fix return value check of
> > wait_for_completion_timeout
> >
> > [External]
> >
> > wait_for_completion_timeout() returns unsigned long not int.
> > It returns 0 if timed out, and positive if completed.
> > The check for <= 0 is ambiguous and should be == 0 here
> > indicating timeout which is the only error case.
> >
> > Fixes: 3cef2e31b54b ("iio: proximity: vl53l0x: Add IRQ support")
> > Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> > ---
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>

Hi Lin,

Just one note regarding the patch subject. You should indicate
to which driver this patch applies "iio: proximity: vl53l0x: ..."

- Nuno Sá