linux-kernel - Re: [BUG] ata: pata_marvell: Warning when probing the module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMhUBjn4HJAy2aXv_M9rSJcZZv7ZihyK3rb5bj2NFyFx6W5dUg@mail.gmail.com>
Date:   Tue, 12 Apr 2022 14:28:39 +0800
From:   Zheyu Ma <zheyuma97@...il.com>
To:     Ozgur <ozgur@...ux.com>
Cc:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] ata: pata_marvell: Warning when probing the module

On Mon, Apr 11, 2022 at 8:09 AM Ozgur <ozgur@...ux.com> wrote:
>
>
>
> 11.04.2022, 02:53, "Damien Le Moal" <damien.lemoal@...nsource.wdc.com>:
>
> On 4/10/22 15:30, Zheyu Ma wrote:
>
>  Hello,
>
>  I found a bug in the pata_marvell module.
>  When probing the driver, it seems to trigger the error path and
>  executes the function marvell_cable_detect(), but the
>  'ap->ioaddr.bmdma_addr' is not initialized, which causes a warning.
>
>
>
> Hello,
> i'm not sure if this is a bug because you get as ap points to a port number.
>
> (ap->port_no)
>
> it points to 0x1 port that appears in error message.

Please correct me if i'm wrong, actually 'ap->port_no' is zero, and
the 'ap->ioaddr.bmdma_addr' is zero too since it is not initialized.

> otherwise BUG will work and if it cannot read warning will return.
> ( BUG(); is macro )

Zheyu Ma